-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcements #398
base: main
Are you sure you want to change the base?
Announcements #398
Conversation
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
Signed-off-by: Florent MILLOT <[email protected]>
…sSubscriber to subscribe to announcements updates. Signed-off-by: Florent MILLOT <[email protected]>
const webSocketBaseUrl = getWsBase(); | ||
return webSocketBaseUrl + PREFIX_CONFIG_NOTIFICATION_WS + '/global'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be inlined
const webSocketBaseUrl = document.baseURI | ||
.replace(/^http:\/\//, 'ws://') | ||
.replace(/^https:\/\//, 'wss://'); | ||
const webSocketBaseUrl = getWsBase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
const webSocketBaseUrl = document.baseURI | ||
.replace(/^http:\/\//, 'ws://') | ||
.replace(/^https:\/\//, 'wss://'); | ||
const webSocketBaseUrl = getWsBase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Add the possibility to see announcements from admins.
Use the hook created in commons-ui gridsuite/commons-ui#405
From #346